Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use --dns-domain for k8s API server cert generation #1589

Merged
merged 2 commits into from
Jun 15, 2017
Merged

use --dns-domain for k8s API server cert generation #1589

merged 2 commits into from
Jun 15, 2017

Conversation

shaneramey
Copy link
Contributor

Fixes #1588

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@r2d4
Copy link
Contributor

r2d4 commented Jun 14, 2017

@minikube-bot ok to test

@codecov-io
Copy link

Codecov Report

Merging #1589 into master will not change coverage.
The diff coverage is 40%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1589   +/-   ##
=======================================
  Coverage   38.85%   38.85%           
=======================================
  Files          51       51           
  Lines        2633     2633           
=======================================
  Hits         1023     1023           
  Misses       1432     1432           
  Partials      178      178
Impacted Files Coverage Δ
pkg/minikube/cluster/cluster.go 44.44% <0%> (ø) ⬆️
pkg/minikube/cluster/credentials.go 50% <50%> (ø) ⬆️
cmd/minikube/cmd/start.go 17.05% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbfd39b...ba423e0. Read the comment docs.

@dlorenc
Copy link
Contributor

dlorenc commented Jun 15, 2017

Thanks!

@dlorenc dlorenc merged commit 084eeaf into kubernetes:master Jun 15, 2017
@shaneramey shaneramey deleted the add_apiserver_dnsdomain_bootstrap branch June 15, 2017 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc dlorenc approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shaneramey @minikube-bot @r2d4 @codecov-io @dlorenc @k8s-ci-robot